Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device address sanitizer example #311

Merged
merged 7 commits into from
Jan 28, 2025
Merged

Add device address sanitizer example #311

merged 7 commits into from
Jan 28, 2025

Conversation

adayton1
Copy link
Member

@adayton1 adayton1 commented Jan 23, 2025 •
edited
Loading

  • Update BLT_CXX_STD default to c++17
  • Update host config to rocm 6.3.0
  • Add working device address sanitizer example

@adayton1 adayton1 requested a review from agcapps January 24, 2025 17:17
robinson96
robinson96 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@robinson96 robinson96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtaller
dtaller approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@dtaller dtaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but an extra comment as I described would be nice

@adayton1 adayton1 merged commit 9583784 into develop Jan 28, 2025
7 checks passed
@adayton1 adayton1 deleted the feature/dayton8/rocm_asan branch January 28, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtaller dtaller dtaller approved these changes

@robinson96 robinson96 robinson96 approved these changes

@liu15 liu15 liu15 approved these changes

@agcapps agcapps Awaiting requested review from agcapps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adayton1 @robinson96 @liu15 @dtaller