-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Unify grafana-operator based setup on k8s/openshift overlays #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergio López <slopezma@redhat.com>
Signed-off-by: Sergio López <slopezma@redhat.com>
Signed-off-by: Sergio López <slopezma@redhat.com>
…verlay Signed-off-by: Sergio López <slopezma@redhat.com>
…vability-hub k8s overlay Signed-off-by: Sergio López <slopezma@redhat.com>
…ty-hub base Signed-off-by: Sergio López <slopezma@redhat.com>
…sword of local-setup grafana UI Signed-off-by: Sergio López <slopezma@redhat.com>
roivaz
requested changes
Feb 24, 2025
…openshift overlay (not used in k8s) Signed-off-by: Sergio López <slopezma@redhat.com>
…lity-hub base Signed-off-by: Sergio López <slopezma@redhat.com>
eaba628
to
354bede
Compare
…ability-hub openshift overlay Signed-off-by: Sergio López <slopezma@redhat.com>
0622913
to
8565dd3
Compare
Signed-off-by: Sergio López <slopezma@redhat.com>
…-worker that enables openshift user-workload-monitoring Signed-off-by: Sergio López <slopezma@redhat.com>
Tested both in k8s and OCP4 and both work as expected. |
roivaz
approved these changes
Mar 3, 2025
Thanks for taking the time to make this change @slopezz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, grafana (part of observability-hub) had a different setup on k8s and openshift:
This PR:
Subscription
Grafana
CR (with some proxy tuning in the case of openshift)GrafanaDatasource
GrafanaDashboard
CR)v1.0.2
GrafanaDashboard
CR (the same approach it was used already on openshift overlay). I wonder if this dashboard should go to https://github.com/Kuadrant/kuadrant-operator/tree/main/examples/dashboards (like the rest of the dashboards)LoadBalancer
, so using the same MetalLB already used for ArgoCD, making easier the usage of Grafana UI with no need of port-forwarding...make
target calledgrafana-url
provide the Grafana MetalLB URL with user/password