Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Office 2k7 colour usages are wrong #297

Closed
Smurf-IV opened this issue Aug 27, 2021 · 9 comments
Closed

[Bug]: Office 2k7 colour usages are wrong #297

Smurf-IV opened this issue Aug 27, 2021 · 9 comments
Labels
area:ribbon All issues to do with the ribbon. area:themes All things to do with themes. bug Something isn't working fixed This issue has been fixed. regression Something was working in a previous release, but isn't working now. version:85-lts All things to do with V85 LTS. version:90 All things to do with V90.

Comments

@Smurf-IV
Copy link
Member

Whilst investigating #227
I found that the colour order usage for O2k7 Themes is reversed

Expected for the orange Backcolor5 (Bottom Glow) to be:
image
image

But for O2k7 Themes (And sparkle):
image
image

@Smurf-IV Smurf-IV added bug Something isn't working area:themes All things to do with themes. labels Aug 27, 2021
Smurf-IV added a commit to Krypton-Suite/Standard-Toolkit-Demos that referenced this issue Aug 29, 2021
@Smurf-IV Smurf-IV added the area:ribbon All issues to do with the ribbon. label Sep 20, 2021
@giduac
Copy link
Contributor

giduac commented Jun 15, 2024

Hi @Smurf-IV,

Is this still being worked on?

@Smurf-IV
Copy link
Member Author

I have been leaving all theme related stuff to wagnerP, unless it has something to do with functionality (As the merges above required highlighting to be done)

@giduac
Copy link
Contributor

giduac commented Jun 15, 2024

@Wagnerp

Is this ticket still current or has it been solved over time?

@PWagner1
Copy link
Contributor

@Wagnerp

Is this ticket still current or has it been solved over time?

@giduac

It's being solved over time, O2k7 themes are the hardest to get right, due to the 'glassy' effect.

@Smurf-IV Smurf-IV added regression Something was working in a previous release, but isn't working now. version:85-lts All things to do with V85 LTS. version:90 All things to do with V90. labels Jul 7, 2024
@Smurf-IV Smurf-IV added this to the Version 85 milestone Jul 7, 2024
@PWagner1
Copy link
Contributor

@Smurf-IV & @giduac

Is the problem that these colours are in the wrong place?

@PWagner1 PWagner1 self-assigned this Sep 21, 2024
@PWagner1 PWagner1 added the under investigation This bug/issue is currently under investigation. label Sep 21, 2024
@Smurf-IV
Copy link
Member Author

@Smurf-IV & @giduac

Is the problem that these colours are in the wrong place?

According to the pictures - Yes

@PWagner1
Copy link
Contributor

Note... Basckcolours 4 & 5 are reversed

@PWagner1
Copy link
Contributor

PWagner1 commented Sep 21, 2024

@Smurf-IV & @giduac

Apparently this was how it was supposed to be. Tested in V4 from CF

{1E57BFB9-4B16-4557-B0F0-E11C861D1DB8}

{829A69DB-040E-4763-9601-953651ACB4C3}

Is this really a bug or a FR?

@PWagner1
Copy link
Contributor

@Smurf-IV & @giduac

Found a fix, going to take a few days to implement, as I'm going to have to reverse back colours 1 & 2 with 5 & 4 and vice-versa for all affected palettes.

PWagner1 added a commit that referenced this issue Sep 22, 2024
PWagner1 added a commit that referenced this issue Sep 28, 2024
PWagner1 added a commit that referenced this issue Sep 29, 2024
@PWagner1 PWagner1 removed their assignment Sep 29, 2024
@PWagner1 PWagner1 added fixed This issue has been fixed. and removed under investigation This bug/issue is currently under investigation. labels Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ribbon All issues to do with the ribbon. area:themes All things to do with themes. bug Something isn't working fixed This issue has been fixed. regression Something was working in a previous release, but isn't working now. version:85-lts All things to do with V85 LTS. version:90 All things to do with V90.
Projects
None yet
Development

No branches or pull requests

3 participants