Make JVM and JS implementations conform to exception contract #23

ilya-g · 2020-07-23T04:52:23Z

No description provided.

dkhalanskyjb

I didn't look at everything yet, but this particular issue should be fairly difficult to fix, so I'm posting this in advance.

core/commonMain/src/Instant.kt

core/commonMain/src/LocalDate.kt

core/jvmMain/src/Instant.kt

core/jsMain/src/Instant.kt

core/nativeMain/src/Util.kt

ilya-g mentioned this pull request Jul 23, 2020

Common: add tests for exceptions and clamping #18

Closed

ilya-g requested a review from dkhalanskyjb July 23, 2020 04:53

dkhalanskyjb requested changes Jul 23, 2020

View reviewed changes

core/commonMain/src/Instant.kt Show resolved Hide resolved

core/commonMain/src/LocalDate.kt Show resolved Hide resolved

dkhalanskyjb requested changes Jul 24, 2020

View reviewed changes

core/jvmMain/src/Instant.kt Show resolved Hide resolved

core/jsMain/src/Instant.kt Outdated Show resolved Hide resolved

core/jsMain/src/Instant.kt Show resolved Hide resolved

core/jsMain/src/Instant.kt Show resolved Hide resolved

Common: add tests for exceptions and clamping

65126f5

ilya-g commented Jul 24, 2020

View reviewed changes

core/jsMain/src/Instant.kt Outdated Show resolved Hide resolved

Reorganize exception and clamping tests to make them more specific

614c6ea

ilya-g force-pushed the jvm-js-exceptions branch from 3140f5b to 3d216b8 Compare July 24, 2020 15:14

ilya-g commented Jul 24, 2020

View reviewed changes

core/nativeMain/src/Util.kt Show resolved Hide resolved

dkhalanskyjb approved these changes Jul 27, 2020

View reviewed changes

ilya-g added 2 commits July 27, 2020 17:48

Make JVM and JS implementations conform to exception contract

2cd6566

Add more tests for 'until'

0fdc611

ilya-g force-pushed the jvm-js-exceptions branch from 3d216b8 to 0fdc611 Compare July 27, 2020 14:49

ilya-g merged commit 0fdc611 into master Jul 27, 2020

ilya-g deleted the jvm-js-exceptions branch July 28, 2020 06:54

ericCHensssssssss mentioned this pull request Dec 17, 2024

we met the "null pointer" exception--kotlinx.datetime.Instant.toString #467

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make JVM and JS implementations conform to exception contract #23

Make JVM and JS implementations conform to exception contract #23

ilya-g commented Jul 23, 2020

dkhalanskyjb left a comment

Make JVM and JS implementations conform to exception contract #23

Make JVM and JS implementations conform to exception contract #23

Conversation

ilya-g commented Jul 23, 2020

dkhalanskyjb left a comment

Choose a reason for hiding this comment