Update GitCheckoutTask, so it re-runs if the repo is dirty #3712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-enko
added
the
infrastructure
IgnatBeresnev
approved these changes
Jul 29, 2024
Currently, GitCheckoutTask might not re-run if the checked-out repository is dirty. This can cause invalid test results. So, update GitCheckoutTask to re-run if the repo does not exist, is invalid, or contains any modifications.
adam-enko
force-pushed
the
adam/feat/OSIP-355/update-GitCheckoutTask
branch
from
f05f310 to
53758fb
Compare
Tapchicoma
reviewed
Jul 30, 2024
- return a result with a more detailed message - add more logging - when checking if a repo is valid, use the `.git` directory - set `parameters.expectedCommitId = commitId`
Tapchicoma
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, GitCheckoutTask might not re-run if the checked-out repository is dirty. This can cause invalid test results.
So, update GitCheckoutTask to re-run if the repo does not exist, is invalid, or contains any modifications.
^OSIP-355