Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[K2] Add a check that source roots do not intersect #3239

Closed
vmishenev opened this issue Oct 19, 2023 · 1 comment · Fixed by #3390 or #3465
Closed

[K2] Add a check that source roots do not intersect #3239

vmishenev opened this issue Oct 19, 2023 · 1 comment · Fixed by #3390 or #3465
Assignees
@vmishenev
Labels
enhancement An issue for a feature or an overall improvement topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Milestone
Dokka 2.0.0

Comments

@vmishenev
Copy link
Contributor

vmishenev commented Oct 19, 2023 •
edited
Loading

Different source sets should have disjoint source roots.
Otherwise, it causes

Modules are inconsistent
org.jetbrains.kotlin.utils.exceptions.KotlinIllegalStateExceptionWithAttachments: Modules are inconsistent
	at org.jetbrains.kotlin.analysis.low.level.api.fir.file.builder.LLFirFileBuilder$buildRawFirFileWithCaching$1.invoke(LLFirFileBuilder.kt:56)

Reproducer: add two source sets with the same source root.

Note: It can complicate the StdLib setting.
@vmishenev vmishenev mentioned this issue Oct 19, 2023
Merged
@vmishenev vmishenev added the topic: K2 Issues / PRs that are related to the K2 migration. See #2888 label Oct 19, 2023
@vmishenev vmishenev changed the title Add a check that source roots do not intersect [K2] Add a check that source roots do not intersect Oct 19, 2023
@vmishenev vmishenev added the enhancement An issue for a feature or an overall improvement label Oct 19, 2023
@IgnatBeresnev
Copy link
Member

Filed an issue to have this check added in KGP as well: https://youtrack.jetbrains.com/issue/KT-62829/Add-a-check-that-two-source-sets-cannot-have-the-same-file-system-directory

But Dokka should also have it because it's possible to misconfigure it manually in CLI and Maven runners.

vmishenev added a commit that referenced this issue Oct 25, 2023
@vmishenev
Fix Modules are inconsistent #3239
b1541fe
@IgnatBeresnev IgnatBeresnev mentioned this issue Nov 10, 2023
Closed
@atyrin atyrin mentioned this issue Nov 24, 2023
Open
@vmishenev vmishenev mentioned this issue Dec 6, 2023
Merged
@IgnatBeresnev IgnatBeresnev reopened this Dec 6, 2023
@vmishenev vmishenev self-assigned this Jan 13, 2024
@vmishenev vmishenev linked a pull request Jan 23, 2024 that will close this issue
[K2] Add a check that source roots do not intersect #3465
Merged
@IgnatBeresnev IgnatBeresnev mentioned this issue Jan 29, 2024
Merged
@IgnatBeresnev IgnatBeresnev added this to the Dokka 2.0.0 milestone Apr 25, 2024
@IgnatBeresnev IgnatBeresnev mentioned this issue May 15, 2024
Closed
@atyrin atyrin mentioned this issue Jul 19, 2024
Open
@whyoleg whyoleg mentioned this issue Aug 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmishenev vmishenev

Labels
enhancement An issue for a feature or an overall improvement topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Projects
None yet
Milestone
Dokka 2.0.0
2 participants
@vmishenev @IgnatBeresnev