Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): auto detection and default to tls #42

Merged
merged 3 commits into from
Dec 7, 2022
Merged

fix(config): auto detection and default to tls #42

merged 3 commits into from
Dec 7, 2022

Conversation

StarlightIbuki
Copy link
Contributor

fix #40

@StarlightIbuki StarlightIbuki requested a review from Tieske December 2, 2022 07:01
Tieske
Tieske requested changes Dec 2, 2022
View reviewed changes
Copy link
Member

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor issue with comment in the wrong position.

Also, can we add a changelog entry?

StarlightIbuki and others added 3 commits December 5, 2022 10:49
@StarlightIbuki
fix(config): auto detection and default to tls
cab0ebd 
fix #40
@StarlightIbuki
fix tests
12e1f38
@StarlightIbuki @Tieske
apply suggestions
ac40e2e 
Co-authored-by: Thijs Schreijer <thijs@thijsschreijer.nl>
@StarlightIbuki StarlightIbuki requested a review from Tieske December 5, 2022 02:51
@Tieske Tieske merged commit c138620 into main Dec 7, 2022
@Tieske Tieske deleted the fix/tls_config branch December 7, 2022 08:56
@Tieske
Copy link
Member

Tieske commented Dec 7, 2022

merged and released in 1.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tieske Tieske Tieske approved these changes

@windmgc windmgc windmgc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tls config requirement
3 participants
@StarlightIbuki @Tieske @windmgc