Crash in dev branch (modernExtend's customTimeResponse?)

[srett]

What happened?

I just pulled and tested the latest dev version. I get crashes every couple minutes:

node[8191]: Error: ReadResponse 0x38398ffffe495a64/1 genTime({"time":1710269134,"localTime":1710272734}, {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":1,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Data request failed with error: 'No network route' (205))
node[8191]:     at ZStackAdapter.sendZclFrameToEndpointInternal (/opt/zigbee2mqtt-dev/node_modules/zigbee-herdsman/src/adapter/z-stack/adapter/zStackAdapter.ts:415:23)
node[8191]:     at Queue.execute (/opt/zigbee2mqtt-dev/node_modules/zigbee-herdsman/src/utils/queue.ts:35:20)
node[8191]:     at Request.send (/opt/zigbee2mqtt-dev/node_modules/zigbee-herdsman/src/controller/helpers/request.ts:79:20)
node[8191]:     at Endpoint.readResponse (/opt/zigbee2mqtt-dev/node_modules/zigbee-herdsman/src/controller/model/endpoint.ts:509:13)
systemd[1]: zigbee2mqtt.service: Main process exited, code=exited, status=1/FAILURE

It seems the exception ends up here and isn't handled any further, but I'm just guessing since async stuff makes my head spin. :)

What did you expect to happen?

Not crashing

How to reproduce it (minimal and precise)

Dunno lol

Zigbee2MQTT version

1.36.0-dev commit: dbd616f

zigbee_herdsman_converters_version
19.0.0

zigbee_herdsman_version
0.37.0

Adapter firmware version

20230507

Adapter

CC2652p

Setup

systemd-nspawn

Debug log

No response

[srett]

OK now I did really update to latest dev and it did actually happen again after a few minutes, so disregard the comment below. The issue persists.

🤦‍♂️

After checking everything like ten times I just realized I was working in a directory with a detached HEAD.

[srett]

OK so someone tried to explain async programming and Promises and stuff to me to no avail but the gist of it is that

data.endpoint.readResponse('genTime', data.meta.zclTransactionSequenceNumber, payload); 

should have an await in front of it :-)

[Koenkk]

Yes it should have an await, do you want to make a PR?

[srett]

Nah it's just one line and I didn't even come up with the fix, you can do it directly. :)

[Koenkk]

committed, thanks!

Changes will be available in the dev branch in a few hours from now.