Fix for activity led activation problem for Wiren Board #7881
Conversation
Fix missing data issue for "Occupancy" parameter
Fix missing data issue for "Occupancy" parameter
Fix missing data issue for "Occupancy" parameter
Update wirenboard.ts
Update wirenboard.ts
| }; | ||
|
|
||
| const sprutModernExtend = { | ||
| sprutActivityIndicator: (args?: Partial<modernExtend.BinaryArgs>) => |
There was a problem hiding this comment.
Can you debug what goes wrong when using the modern extend? It's the preferred way to do this.
There was a problem hiding this comment.
When using a modern extend up to version 1.39.0 (inclusive) everything works correctly. But in version 1.39.1, modernExtend.js added the "autoDetectInputEndpoint" function, which leads to an unexpected result:
zh:controller:endpoint: ZCL command 0x7cc6b6fffe5f655b/1 genBinaryOutput.write({"presentValue":1}, {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null,"writeUndiv":false})
and I expect:
zh:controller:endpoint: ZCL command 0x7cc6b6fffe5f655b/5 genBinaryOutput.write({"presentValue":1}, {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null,"writeUndiv":false})
As far as I understand, the command is now sent to endpoint 1 instead of 5. The sensor freezes.
Using the "entity" function as in previous versions fixes this.
There was a problem hiding this comment.
Could you provide the data/database.db entry of this device?
There was a problem hiding this comment.
database in case of clean installation of z2m 1.39.1:
database.db.zip
database in the case of proposed fix:
database.db.zip
There was a problem hiding this comment.
It puzzles me why the code you propose in this PR sends it to ep 5 and not to 1, could you provide the debug log when setting the activity_led with your fix included?
See this on how to enable debug logging.
There was a problem hiding this comment.
There was a problem hiding this comment.
I found the issue, attempted to fix it in #7896
Changes will be available in the dev branch in a few hours from now.
There was a problem hiding this comment.
Checked it out, problem's gone. Thank you.
Update wirenboard.ts