[api] Remove ICR artifacts #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psparacino
requested review from
Atmosfearful,
0xemc,
0xMakka,
biwano and
sprrwhwk
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
biwano
approved these changes
Jan 23, 2024
psparacino
force-pushed
the
tufnel/remove-serialization
branch
from
6d3952e to
53a0166
Compare
psparacino
force-pushed
the
tufnel/remove-serialization
branch
from
53a0166 to
f29a55a
Compare
0xemc
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the original version of the ICR integration, ICR's project credit
serializationwas the only reliable way to query the ICR api for a specific project.After the refactor to use the cms for project data, the serialization is only needed to create the
registry-registryProjectIDformat to identify the project when querying the ICR subgraph for ICR holdings. The serialization can be removed everywhere else.In the app, besides generated files, the serialization only exists as a prop in carbonmark/lib/createUrls and will be deleted there for the APP PR for this api version.
The end goal is not to use the serialization anywhere in the CM codebase. Once we can query ICR holdings from a CM subgraph this last requirement can be removed.
Related Ticket
related to 2093