-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APP] ICR FE Integration #2052
Merged
Merged
[APP] ICR FE Integration #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aa4697c
to
bd69622
Compare
This was referenced Dec 21, 2023
bd69622
to
3d03928
Compare
3d03928
to
1267746
Compare
1267746
to
0cc780b
Compare
5fe8f99
to
f2e2802
Compare
f2e2802
to
159e0d1
Compare
159e0d1
to
f4193c7
Compare
biwano
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Carbonmark Integration for ICR credits
Notes for reviewers:
serialization
is one of three possible query parameters for an individual on the ICR api.serialization
is used over the other two options (contractAddress
and ICR's version of aprojectID
) whenever possible for consistency.To change before merge:
Other improvements were noted along the way that weren't necessarily ICR specific but were rolled into this PR:
Related Ticket
Also related to #2051
Notes For QA
Specific pages, components or journeys that might be affected:
Relevant preview URLs:
Other notes: