Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APP] ICR FE Integration #2052

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

psparacino
Copy link
Collaborator

@psparacino psparacino commented Dec 20, 2023

Description

Carbonmark Integration for ICR credits

Notes for reviewers:

  1. The retirement data for receipts in dependent on merge of [KLIMADAO/Klimadao] Polygon-digital-carbon for retirement data #2048 . This will eventually all be moved to an endpoint.
  2. serialization is one of three possible query parameters for an individual on the ICR api. serialization is used over the other two options (contractAddress and ICR's version of a projectID) whenever possible for consistency.
  3. ICR quantities are regular integers, so the amounts are handled separately for the ICR registry here.
  4. This PR uses a mainnet testing setup: mainnet RA, carbonmark contract, ICR Carbon Registry contract, ICR subgraph, digital-carbon and marketplace subgraphs. These all need to be changed to production versions before merge.
  5. The API is currently hardcoded to the API PR Preview [API] ICR API Integration #2051 . This should be removed before merge.

To change before merge:

  • AggregatorV2 contract
  • Carbonmark contract
  • ICR Carbon Registry contract
  • ICR subgraph
  • Digital-carbon subgraph
  • Marketplace subgraph
  • Hardcoded Preview URL

Other improvements were noted along the way that weren't necessarily ICR specific but were rolled into this PR:

  1. Removing duplicate prices or quantities when only editing one option in a listing: here
  2. Fix recurring nesting error because of title construction in Text component here

Related Ticket

Also related to #2051

Notes For QA

Specific pages, components or journeys that might be affected:

  • All need to be tested

Relevant preview URLs:

Other notes:

  • This is a large PR(!). Please feel free to reach out for any clarification or to pair review any specific section.

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 3:46pm
carbonmark ✅ Ready (Inspect) Visit Preview Jan 22, 2024 3:46pm
carbonmark-api ✅ Ready (Inspect) Visit Preview Jan 22, 2024 3:46pm
demo-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 3:46pm
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 3:46pm

@psparacino psparacino force-pushed the APP_feature/icr-api-integration branch from aa4697c to bd69622 Compare December 20, 2023 21:03
@psparacino psparacino deployed to Preview – carbonmark-api December 20, 2023 21:03 — with GitHub Actions Active
@psparacino psparacino force-pushed the APP_feature/icr-api-integration branch from bd69622 to 3d03928 Compare January 8, 2024 15:56
@psparacino psparacino force-pushed the APP_feature/icr-api-integration branch from 3d03928 to 1267746 Compare January 10, 2024 18:15
@psparacino psparacino force-pushed the APP_feature/icr-api-integration branch from 1267746 to 0cc780b Compare January 10, 2024 18:31
@psparacino psparacino merged commit f1e848f into staging Jan 22, 2024
7 checks passed
@psparacino psparacino deleted the APP_feature/icr-api-integration branch January 22, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants