Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: migrate to pnpm #5523

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

WIP: migrate to pnpm #5523

wants to merge 21 commits into from

Conversation

pierremtb
Copy link
Collaborator

Quick attempt at a pnpm migration. Seems to work better with vercel out of the box and the setup-node action. Electron Forge just added support for it in 7.7.0. Big diff as we need to specify peer dependencies too afaik

Copy link

qa-wolf bot commented Feb 26, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 27, 2025 9:53pm

@pierremtb pierremtb changed the title Pierremtb/adhoc/pnpm WIP: migrate to pnpm Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.41%. Comparing base (850c5c6) to head (d715a8b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5523      +/-   ##
==========================================
- Coverage   86.43%   86.41%   -0.02%     
==========================================
  Files          97       97              
  Lines       37194    37194              
==========================================
- Hits        32150    32143       -7     
- Misses       5044     5051       +7     
Flag Coverage Δ
wasm-lib 86.41% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant