Skip to content
This repository was archived by the owner on Oct 2, 2020. It is now read-only.

Add M.2 TE 2199230 series footprints #1404

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

samt
Copy link

@samt samt commented Feb 11, 2019

Add M.2 TE 2199230 series footprints


Datasheets and Screenshots:

2199230-8 M.2 A-KEY
screen shot 2019-02-12 at 14 04 08

2199230-3 M.2 B-KEY
screen shot 2019-02-12 at 14 04 13

2199230-4 M.2 E-KEY
screen shot 2019-02-12 at 14 04 20

1-2199230-5 M.2 M-KEY
screen shot 2019-02-12 at 14 04 24

Other Notes

  • I've included placeholder 3d models to be added at a later date
  • Cross-checked keying with wikipedia article on M.2
  • Printed (on paper) and roughly verified everything is correctly positioned with the parts I have on my desk

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@samt samt force-pushed the te-m2-connectors branch 5 times, most recently from cc5d1f7 to 804dbc0 Compare February 11, 2019 21:33
@samt samt closed this Feb 12, 2019
@samt samt reopened this Feb 12, 2019
@samt
Copy link
Author

samt commented Feb 12, 2019

I made some minor tweaks since the screenshots to make the grid align with 0.01mm, but it should be good to go.

I have no models yet and symbols are also to come.

@myfreescalewebpage myfreescalewebpage added the Addition Adds new footprint to library label Feb 12, 2019
@myfreescalewebpage myfreescalewebpage self-assigned this Feb 12, 2019
@myfreescalewebpage
Copy link
Collaborator

Hello @samt thanks for contributing !
For this PR we will have to consider also #879.
We are also currently reviewing #1124 and it's good if we can do something consistent.
I will do a review according to choices on the two above PR too.
Cheers,
Joel

@samt
Copy link
Author

samt commented Mar 3, 2019

Hi, @myfreescalewebpage - I wanted to check on the status of this and if there is any action needed on my part. Thanks!

@myfreescalewebpage
Copy link
Collaborator

Hi @samt
We are quite busy at this moment because of the 5.1 release, and we try to integrate important fixes.
I have not made a complete review of the footprint right now, they look good, but I'm waiting some strategic decisions in the PR attached in my previous comment to indicate you if some changes are required.
I will keep you in touch asap anyway, do not worry, but I think this will take a while.
Thanks for your understanding,
Joel

@evanshultz
Copy link
Collaborator

I would like to name these by the keying and connector height, so the 3D model can match, since they are a standard. This would be something like M.2_<key>_<height> where <key> is A, B, E, or M and <height> is H2.25mm, H3.2mm, 4.2mm, or <MidPlane>.

And then put them into a different repo like what was discussed starting at #1124 (comment). Let's try not to spread the conceptual part of the discussion around, if we can.

A few things I can see above:

  1. It looks like silk is on top of the fab lines, which should be at the component edges, but silk should be offset. Can you move it, say, 0.11mm outside of the fab lines?
  2. Fab lines should be a rectangle at the component extents.
  3. There can be silk lines across the key (gap in the pads).

Is all that OK?

@myfreescalewebpage
Copy link
Collaborator

@evanshultz for consistency with other footprints I propose Bus_M.2_<key>_<height> format

@samt
Copy link
Author

samt commented Oct 28, 2019

Sorry this is months late, I believe I was traveling and missed the notifications here.

@evanshultz I'll make the requested changes, but was confused here:

And then put them into a different repo like what was discussed starting at #1124 (comment). Let's try not to spread the conceptual part of the discussion around, if we can.

Do you mean to put this in a separate tree within this repo? I know I have a fab drawing to indicate where the card edge goes to, but thats not a cut line at all.

In addition, should I create new footprints or modify these to indicate where the mounting screws go? IIRC, there are a few standard lengths but I also put the card edge so a user can measure it for his or herself.

@poeschlr
Copy link
Collaborator

Does this contain the same parts as #1929

@samt
Copy link
Author

samt commented Oct 28, 2019

It appears so. I have no preference, personally. I just use the M.2 footprint and this is the one I've been using.

@poeschlr
Copy link
Collaborator

poeschlr commented Nov 3, 2019

I disagree with the assessment by evan that such connectors would not fit into the footprint repo. What does not fit is something that defines a full outline but the partial outline of a connector alone is fully ok. And most importantly this contribution does not even define any edge cut as it is for the connector that receives such board edge connector.


Review:

The body outline is missing.
Move the remarks to the cmts.user (text) and dwgs.user (graphics) layers.
The pads for the mounting pads would need the pad number MP.
The fab reference should be inside the body outline (preferably at the center)


From a KLC standpoint i would say the duplication of this might be a better fit. (So it might be less work for @ki5libs to get their contribution ready for merging than it would be for you.)

@samt
Copy link
Author

samt commented Nov 10, 2019

I noticed a small issue when using the 2-row, 75 pin connected that was merged back in May (KiCad/kicad-library-utils#272). The pin counts were not matching up because M.2 always has a key, which is effectively a chunk of "missing" pins. For example, in an M.2 E-Key setup, pins 24-31 are missing, but the numbering continues at pin 32.

What should happen here, exactly? Do I need to make each one with no-op pads? Do we need different symbols per key instead?

@myfreescalewebpage myfreescalewebpage removed their assignment Nov 10, 2019
@myfreescalewebpage myfreescalewebpage added the Pending reviewer A pull request waiting for a reviewer label Nov 10, 2019
@samt
Copy link
Author

samt commented Nov 11, 2019

Updated footprints

A Key

M.2 Connector footprint A-Key

B Key

M.2 Connector footprint B-Key

E Key

M.2 Connector footprint E-Key

M Key

M.2 Connector footprint M-Key


Changes

  • Added body outline
  • Remarks on correct layers
  • Mounting pads are named 'MP'
  • Fab ref is inside fab lines
  • It looks like silk is on top of the fab lines, which should be at the component edges but silk should be offset. Can you move it, say, 0.11mm outside of the fab lines?
  • Fab lines should be a rectangle at the component extents.
  • There can be silk lines across the key (gap in the pads).

For what it's worth, I made a script to do these changes. The template sits in its own .pretty folder which I load into the footprint editor for editing and I have a script that modifies/populates the resulting template and copies it to a new location. I have it doing 4 variations, one for each key.

https://gist.github.com/samt/db077785ddf99e2797c9d65ee49022d4

@HackInvent HackInvent mentioned this pull request Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants