-
Notifications
You must be signed in to change notification settings - Fork 710
Add M.2 TE 2199230 series footprints #1404
base: master
Are you sure you want to change the base?
Conversation
cc5d1f7
to
804dbc0
Compare
804dbc0
to
bdb12e8
Compare
f1cf3e9
to
98c0551
Compare
I made some minor tweaks since the screenshots to make the grid align with 0.01mm, but it should be good to go. I have no models yet and symbols are also to come. |
Hi, @myfreescalewebpage - I wanted to check on the status of this and if there is any action needed on my part. Thanks! |
Hi @samt |
I would like to name these by the keying and connector height, so the 3D model can match, since they are a standard. This would be something like And then put them into a different repo like what was discussed starting at #1124 (comment). Let's try not to spread the conceptual part of the discussion around, if we can. A few things I can see above:
Is all that OK? |
@evanshultz for consistency with other footprints I propose |
Sorry this is months late, I believe I was traveling and missed the notifications here. @evanshultz I'll make the requested changes, but was confused here:
Do you mean to put this in a separate tree within this repo? I know I have a fab drawing to indicate where the card edge goes to, but thats not a cut line at all. In addition, should I create new footprints or modify these to indicate where the mounting screws go? IIRC, there are a few standard lengths but I also put the card edge so a user can measure it for his or herself. |
Does this contain the same parts as #1929 |
It appears so. I have no preference, personally. I just use the M.2 footprint and this is the one I've been using. |
I disagree with the assessment by evan that such connectors would not fit into the footprint repo. What does not fit is something that defines a full outline but the partial outline of a connector alone is fully ok. And most importantly this contribution does not even define any edge cut as it is for the connector that receives such board edge connector. Review: The body outline is missing. From a KLC standpoint i would say the duplication of this might be a better fit. (So it might be less work for @ki5libs to get their contribution ready for merging than it would be for you.) |
I noticed a small issue when using the 2-row, 75 pin connected that was merged back in May (KiCad/kicad-library-utils#272). The pin counts were not matching up because M.2 always has a key, which is effectively a chunk of "missing" pins. For example, in an M.2 E-Key setup, pins 24-31 are missing, but the numbering continues at pin 32. What should happen here, exactly? Do I need to make each one with no-op pads? Do we need different symbols per key instead? |
98c0551
to
120e79a
Compare
08d3c95
to
b431f02
Compare
Updated footprintsA KeyB KeyE KeyM KeyChanges
For what it's worth, I made a script to do these changes. The template sits in its own https://gist.github.com/samt/db077785ddf99e2797c9d65ee49022d4 |
b431f02
to
4f95c5c
Compare
Add M.2 TE 2199230 series footprints
Datasheets and Screenshots:
2199230-8 M.2 A-KEY

2199230-3 M.2 B-KEY

2199230-4 M.2 E-KEY

1-2199230-5 M.2 M-KEY

Other Notes
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: