clarify clEnqueueReleaseExternalMemObjectsKHR #1332
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashbaug
commented
Mar 4, 2025
Comment on lines
+5878
to
+5879
| {clEnqueueReleaseExternalMemObjectsKHR} before using them through any commands | ||
| outside of OpenCL. |
There was a problem hiding this comment.
Possible additional improvements:
- Disambiguate "them", because the memory objects do not have any meaning outside of OpenCL. Should this be referring to the external memory handles used to create the memory objects instead? Should it be the memory that those handles represent?
- Disambiguate "any commands". Should this be "functions" instead? What is the right term?
|
Converting to a draft while we determine how to make additional improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial fix for #1308
This changes the text in the description of clEnqueueReleaseExternalMemObjectsKHR from "in the other API" to "outside of OpenCL".