Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document img 1x2_2x2 matmul functions. #1283

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

cycheng
Copy link
Contributor

@cycheng cycheng commented Nov 11, 2024

Document the following 1x2_2x2 matmul functions:

float2 img_matmul_float_acc_1x2_2x2(float2 a, __local float4 * b, float2 acc)
float2 img_matmul_half2_acc_1x2_2x2f(half4 a, __local half8 * b, float2 acc)
half2 img_matmul_half2_acc_1x2_2x2h(half4 a, __local half8 * b, half2 acc)
uint2 img_matmul_uchar4_acc_1x2_2x2(uchar8 a, __local uchar16 * b, uint2 acc);
int2 img_matmul_char4_acc_1x2_2x2(char8 a, __local char16 * b, int2 acc);
int2 img_matmul_char4_acc_1x2_2x2(uchar8 a, __local char16 * b, int2 acc);
int2 img_matmul_char4_acc_1x2_2x2(char8 a, __local uchar16 * b, int2 acc);
uint2 img_matmul_uchar4_acc_1x2_2x2_sat(uchar8 a, __local uchar16 * b, uint2 acc);
int2 img_matmul_char4_acc_1x2_2x2_sat(char8 a, __local char16 * b, int2 acc);
int2 img_matmul_char4_acc_1x2_2x2_sat(char8 a, __local uchar16 * b, int2 acc);
int2 img_matmul_char4_acc_1x2_2x2_sat(uchar8 a, __local char16 * b, int2 acc);

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial note: I suggest checking the rendered HTML to ensure that the text is wrapping the way you would like it to wrap, especially in some of the examples showing how the matmul operation takes place.

@@ -299,5 +501,5 @@ res = [ 1.000000 2.000000 3.000000 4.000000 ]
|====
| Version | Date | Author | Changes
| 1.0.0 | 2024-06-07 | Tomasz Platek | *Initial revision*
| 1.0.0 | 2024-11-11 | CY Cheng | Document 1x2_2x2 matrix functions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming: do you want this extension to have the same version number even though it is adding functionality?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, bashbaug! Increasing the version seems better, should I increment the 'Minor' or 'Patch' version?

@cycheng
Copy link
Contributor Author

cycheng commented Nov 19, 2024

Editorial note: I suggest checking the rendered HTML to ensure that the text is wrapping the way you would like it to wrap, especially in some of the examples showing how the matmul operation takes place.

Thank you! Confirmed again with two different renderers.

@bashbaug
Copy link
Contributor

Discussed in the December 10th teleconference. @paulfradgley will give this a final review and if everything looks good we're OK to merge.

@paulfradgley paulfradgley merged commit 34bc564 into KhronosGroup:main Dec 17, 2024
2 checks passed
aharon-abramson pushed a commit to aharon-abramson/OpenCL-Docs that referenced this pull request Feb 27, 2025
* document img 1x2_2x2 matmul functions.

* Correct the description of matmul with saturation.

* Address review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants