-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document img 1x2_2x2 matmul functions. #1283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial note: I suggest checking the rendered HTML to ensure that the text is wrapping the way you would like it to wrap, especially in some of the examples showing how the matmul operation takes place.
@@ -299,5 +501,5 @@ res = [ 1.000000 2.000000 3.000000 4.000000 ] | |||
|==== | |||
| Version | Date | Author | Changes | |||
| 1.0.0 | 2024-06-07 | Tomasz Platek | *Initial revision* | |||
| 1.0.0 | 2024-11-11 | CY Cheng | Document 1x2_2x2 matrix functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming: do you want this extension to have the same version number even though it is adding functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, bashbaug! Increasing the version seems better, should I increment the 'Minor' or 'Patch' version?
Thank you! Confirmed again with two different renderers. |
Discussed in the December 10th teleconference. @paulfradgley will give this a final review and if everything looks good we're OK to merge. |
* document img 1x2_2x2 matmul functions. * Correct the description of matmul with saturation. * Address review comments.
Document the following 1x2_2x2 matmul functions: