-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate OpenCL C feature dictionary #1212
Conversation
Features are stored in a text file for now. Ultimately, we probably want to use the XML registry for this. Generation script taken from KhronosGroup#1174 with a few modifications. Contributes to KhronosGroup#1166. Signed-off-by: Ben Ashbaugh <ben.ashbaugh@intel.com> Signed-off-by: Kevin Petit <kevin.petit@arm.com> Change-Id: Ie2c14148d75457030aa1a97cf601daba2c007397
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice improvement!
Once this goes in I might look at generalizing it for other uses in the OpenCL C spec. For example, it might be useful to have dictionaries for long built-in function names, to fix #1214.
Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com>
Signed-off-by: Kevin Petit <kevin.petit@arm.com> Change-Id: I8e0947c30775338dd70803d09c7059d340e86f5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Generate OpenCL C feature dictionary Features are stored in a text file for now. Ultimately, we probably want to use the XML registry for this. Generation script taken from KhronosGroup#1174 with a few modifications. Contributes to KhronosGroup#1166. Signed-off-by: Ben Ashbaugh <ben.ashbaugh@intel.com> Signed-off-by: Kevin Petit <kevin.petit@arm.com> Change-Id: Ie2c14148d75457030aa1a97cf601daba2c007397 * Update scripts/gen_c_feature_dictionary.py Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com> * define __opencl_c_<feature_name> outside of the list of features Signed-off-by: Kevin Petit <kevin.petit@arm.com> Change-Id: I8e0947c30775338dd70803d09c7059d340e86f5a --------- Signed-off-by: Ben Ashbaugh <ben.ashbaugh@intel.com> Signed-off-by: Kevin Petit <kevin.petit@arm.com> Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com>
Features are stored in a text file for now. Ultimately, we probably want to use the XML registry for this.
Generation script taken from #1174 with a few modifications.
Contributes to #1166.
Change-Id: Ie2c14148d75457030aa1a97cf601daba2c007397