GitHub Action fixes #920
Merged
GitHub Action fixes #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which now sets an environment variable to an empty string when the corresponding matrix attribute is not set. The fix has two parts: always set the generator in the matrix and use IsNullOrEmpty in the script to test if the default should be used.
MarkCallow
added a commit
that referenced
this pull request
Jun 30, 2024
Unbelievable. While still wrangling with the workaround for the major GHA Windows runner image meltdown (PR #920 and blocked-by-this PR #923) Travis breaks their Ubuntu/arm64 runner image such that installs of python-related tools on to the VM are failing. This is their suggested workaround. I don't yet know if it will be needed permanently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for new GHA 2024.06.10.1.0 runner image behavior w.r.t setting env. vars from build matrix.
Workaround 2024.06.03.1.0 GHA runner image bug that continues in 2024.06.10.1.0. See actions/runner-images#10004.