Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect NORMALIZED format result from interpretDFD #738

Closed
MarkCallow opened this issue Jul 12, 2023 · 0 comments · Fixed by #739
Closed

Incorrect NORMALIZED format result from interpretDFD #738

MarkCallow opened this issue Jul 12, 2023 · 0 comments · Fixed by #739

Comments

@MarkCallow
Copy link
Collaborator

The test at line 130 in interpretdfd.c is using the counter from a previous loop. The counter in the loop this is in is i.

        if (KHR_DFDSVAL(BDFDB, sampleCounter, BITLENGTH) > 0)
            hasNormalized |= isNormalized;

The fix is s/asampleCounter/i/.

sampleCounter, having been used in a previous loop, always equals the number of samples. Therefore I am surprised this error has not been causing crashes.
@MarkCallow MarkCallow mentioned this issue Jul 12, 2023
Merged
MarkCallow added a commit that referenced this issue Jul 13, 2023
@MarkCallow
Use correct counter for indexing sample. (#739)
3153e94 
Fixes #738.
KaperD pushed a commit to KaperD/KTX-Software that referenced this issue Feb 21, 2024
@MarkCallow
Use correct counter for indexing sample. (KhronosGroup#739)
2705240 
Fixes KhronosGroup#738.
KaperD pushed a commit to KaperD/KTX-Software that referenced this issue Feb 22, 2024
@MarkCallow
Use correct counter for indexing sample. (KhronosGroup#739)
05de78b 
Fixes KhronosGroup#738.
KaperD pushed a commit to KaperD/KTX-Software that referenced this issue Feb 22, 2024
@MarkCallow
Use correct counter for indexing sample. (KhronosGroup#739)
692b5db 
Fixes KhronosGroup#738.
KaperD pushed a commit to KaperD/KTX-Software that referenced this issue Feb 22, 2024
@MarkCallow
Use correct counter for indexing sample. (KhronosGroup#739)
300514d 
Fixes KhronosGroup#738.
KaperD pushed a commit to KaperD/KTX-Software that referenced this issue Feb 22, 2024
@MarkCallow
Use correct counter for indexing sample. (KhronosGroup#739)
78595fe 
Fixes KhronosGroup#738.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use correct counter for indexing sample. KhronosGroup/KTX-Software
1 participant
@MarkCallow