Migrate to pnpm #1123
Migrate to pnpm #1123
Conversation
…s to use workspace)
…es to build docs for
|
| @@ -17,16 +17,16 @@ | |||
| "main": "dist/index.js", | |||
| "types": "dist/index.d.ts", | |||
| "scripts": { | |||
| "test": "bash -c 'yarn --silent --cwd \"../..\" test ${@:0} $($([[ ${@: -1} = -* ]] || [[ ${@: -1} = bash ]]) && echo $PWD)'" | |||
| "test": "bash -c 'pnpm --silent --dir \"../..\" test ${@:0} $($([[ ${@: -1} = -* ]] || [[ ${@: -1} = bash ]]) && echo $PWD)'" | |||
There was a problem hiding this comment.
Despite some work, I cannot get this to work. It runs, but does not run any tests.
I'm inclined to remove these test scripts from each of these packages. I don't know that anyone uses them and running tests from the root is quite easy (including the ability to filter to a single package by running pnpm test packages/wonder-stuff-ci).
Summary:
This PR migrates this repo to pnpm. After the initial import, there were several changes I had to make to get all the
scriptsworking. Many of these were the result ofyarnresolving modules through the workspace root'snode_moduleswhereaspnpmputs anode_modulesdir in each package's dir.Changes include:
post-installscript unless it's approved) #securitycheck-type-definitions.jsso thatpnpm build:typesworkspre-publish-check-ci.jsdocs/directoryeslint-plugin-khanthat used to be available implicitly by yarntypedoc.config.jsto be CJSIssue: FEI-6300
Test plan:
I ran each of the scripts in
package.jsonincluding thepublish:ci(which I temporarily modified to not do the last step which acctually publishes).