[FEI-6106]: Integrating Announcer into WB SingleSelect and MultiSelect #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ff24d0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
marcysutton
changed the title
|
Size Change: +2.15 kB (+2.19%) Total Size: 101 kB
ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-fmxpqrhsfr.chromatic.com/ Chromatic results:
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (59e23d0) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2478"Packages can also be installed manually by running: pnpm add @khanacademy/wonder-blocks-<package-name>@PR2478 |
marcysutton
changed the title
marcysutton
force-pushed
the
combobox-announcer
branch
from
fb95738 to
a8a49bf
Compare
The initial implementation for a live region component! I'm getting this draft PR up so I can test with the remote URL. Issue: https://khanacademy.atlassian.net/browse/WB-1768 Outstanding questions/work areas: - Testing in more ATs, particularly in webapp and on mobile devices. - More integration with React: usage for JSX, debouncing with custom duration in continuously re-rendering components like the Video Player with Clarifications, etc. Play with the Story with screen readers turned on 1. VoiceOver on OSX 2. VoiceOver on iOS 3. NVDA on Windows 4. JAWS on Windows Author: marcysutton Reviewers: jandrade, marcysutton, beaesguerra, nishasy, nedredmond, #wonder-blocks Required Reviewers: Approved By: beaesguerra Checks: ⌛ Test / Test (ubuntu-latest, 20.x, 2/2), ⌛ Lint / Lint (ubuntu-latest, 20.x), ⌛ Test / Test (ubuntu-latest, 20.x, 1/2), ⌛ Check build sizes (ubuntu-latest, 20.x), ⌛ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ⌛ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ⏭️ Chromatic - Skip on Release PR (changesets), ✅ gerald, ⏭️ dependabot Pull Request URL: #2362
…r ARIA Live Regions
…announcements in SingleSelect and MultiSelect
marcysutton
force-pushed
the
combobox-announcer
branch
from
7ca04df to
ff24d0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing out some updates to the WB SingleSelect and MultiSelect to use the Announcer for updating values.
I'm using this PR to test the snapshot URL on various devices.
TO-DO:
Issue: WB-1891