Skip to content

Ordination plots should use equally scaled axes #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gavinsimpson
Copy link

This PR fixes the problem with ordination diagrams raise in Issue #176 through the use of ggplot2::coord_fixed() to make the axes of the plot use equal scaling.

@KasperSkytte
Copy link
Owner

I'd rather make this optional with a default, since it wouldn't be easily turned off by the user.

@gavinsimpson
Copy link
Author

Then you misunderstand the problem; these are incorrect plots if you don't use a plot with the same scale on both axes, the biplot interpretations are messed up. I don't think we should give users the option to create incorrect plots.

@gavinsimpson
Copy link
Author

I may not have fully understood all the options in your code and add the equal scaling to all plots - if so, that wasn't intentional and the correct fix is to apply this to those plots when two ordination axes are being plotted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants