Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple mappers for each class #72

Merged
merged 5 commits into from
Nov 12, 2023
Merged

Support multiple mappers for each class #72

merged 5 commits into from
Nov 12, 2023

Conversation

iruizmar
Copy link
Contributor

Closes #70

luca992
luca992 requested changes Nov 12, 2023
View reviewed changes
Copy link
Member

@luca992 luca992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides that

@luca992
Copy link
Member

luca992 commented Nov 12, 2023

Sorry, I looked at it again, and made more change requests

@iruizmar
Copy link
Contributor Author

iruizmar commented Nov 12, 2023 •
edited
Loading

Sorry, I looked at it again, and made more change requests

@luca992 Sure! I think you forgot to send them, though.

@luca992
Copy link
Member

luca992 commented Nov 12, 2023

Sorry, I looked at it again, and made more change requests

@luca992 Sure! I think you forgot to send them, though.

I think you should be able to see them above. Lmk if you do not

@iruizmar
Copy link
Contributor Author

Sorry, I looked at it again, and made more change requests

@luca992 Sure! I think you forgot to send them, though.

I think you should be able to see them above. Lmk if you do not

Can't see anything, mate! Maybe you started a review and didn't send it?

@luca992
Copy link
Member

luca992 commented Nov 12, 2023

Sorry, I looked at it again, and made more change requests

@luca992 Sure! I think you forgot to send them, though.

I think you should be able to see them above. Lmk if you do not

Can't see anything, mate! Maybe you started a review and didn't send it?

Sorry, thought I added them to the old review. I guess not.

@iruizmar
Copy link
Contributor Author

Sorry, I looked at it again, and made more change requests

@luca992 Sure! I think you forgot to send them, though.

I think you should be able to see them above. Lmk if you do not

Can't see anything, mate! Maybe you started a review and didn't send it?

Sorry, thought I added them to the old review. I guess not.

@luca992 all good. I addressed them.

@luca992 luca992 merged commit bb4cc60 into Kamel-Media:main Nov 12, 2023
@luca992
Copy link
Member

luca992 commented Nov 12, 2023

Sweet looks good. Thanks!

@iruizmar iruizmar deleted the support-multiple-mappers branch November 12, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luca992 luca992 luca992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multiple mappers per input class type
2 participants
@iruizmar @luca992