fix: ci integration tests chopsticks #839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode into ag_chopsticks_design
abdulmth
previously approved these changes
Feb 11, 2025
rflechtner
previously approved these changes
Feb 13, 2025
integration-tests/chopsticks/src/tests/switchPallet/pause/sendRelayToken/index.test.ts
Outdated
Show resolved
Hide resolved
integration-tests/chopsticks/src/tests/switchPallet/pause/switchEkilts/index.test.ts
Outdated
Show resolved
Hide resolved
integration-tests/chopsticks/src/tests/switchPallet/pause/switchKilts/index.test.ts
Outdated
Show resolved
Hide resolved
rflechtner
previously approved these changes
Feb 18, 2025
| deltaStoredSovereignSupply = BigInt(0) | ||
| ) { | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| const switchPairInfo: any = await nativeContext.api.query.assetSwitchPool1.switchPair() |
There was a problem hiding this comment.
we don't have access to the actual codec types for this pallet unless you import them from @kiltprotocol/augment-api, but many common types are available from @polkadot/types/interfaces. The Option Codec is one another basic codec type, and is available from @polkadot/types. Typescript has generics syntax just like rust, and types (like an Option Codec type) can be generic.
| deltaStoredSovereignSupply = BigInt(0) | ||
| ) { | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| const switchPairInfo: any = await nativeContext.api.query.assetSwitchPool1.switchPair() |
There was a problem hiding this comment.
I've made a more useful example of specifying the query return type earlier in this second review
integration-tests/chopsticks/src/tests/switchPallet/pause/switchKilts/index.test.ts
Outdated
Show resolved
Hide resolved
| afterEach(async () => { | ||
| await tearDownNetwork([receiverContext, senderContext, relayContext]) | ||
| }) | ||
| afterEach(async () => await tearDownNetwork([receiverContext, senderContext, relayContext])) |
There was a problem hiding this comment.
the syntax you used before was completely fine; this one is ok too though, but unusual. To summarize, these are ok:
// Returns a resolved promise containing the result of tearDownNetwork
afterEach(async () => await tearDownNetwork([receiverContext, senderContext, relayContext]))
// Returns a promise of tearDownNetwork's result directly, but is functionally identical to the above (indistinguishable for the caller)
afterEach(async () => tearDownNetwork([receiverContext, senderContext, relayContext]))
// Also returns a promise, because tearDownNetwork is async (but would be sync if tearDownNetwork were sync) - also functionally identical
afterEach(() => tearDownNetwork([receiverContext, senderContext, relayContext]))
// Same as above but with brackets
afterEach(() => {return tearDownNetwork([receiverContext, senderContext, relayContext]))}
// Also the same as earlier but with brackets
afterEach(async () => {return await tearDownNetwork([receiverContext, senderContext, relayContext]))}
// Not strictly the same - this returns a `Promise<void>` (but if tearDownNetwork did too, this would be functionally identical again)
afterEach(async () => {await tearDownNetwork([receiverContext, senderContext, relayContext]))}Don't do this though:
// Uncaught promise - the result is not handled nor awaited. The outer function always resolves.
afterEach(async () => {tearDownNetwork([receiverContext, senderContext, relayContext]))}
// Uncaught promise - the result is not handled nor awaited. The outer function is sync and returns void immediately.
afterEach(() => {tearDownNetwork([receiverContext, senderContext, relayContext]))}
// Illegal use of await in sync function
afterEach(() => {await tearDownNetwork([receiverContext, senderContext, relayContext]))}There was a problem hiding this comment.
oh yes sorry I forgot the await there: 6e71bf1
integration-tests/chopsticks/src/tests/xcm/initiateWithdrawAsset/index.test.ts
Outdated
Show resolved
Hide resolved
| } | ||
| /// Schedules a transaction with root privileges at the given block number. If no block is provided, the transaction will be scheduled for the next block. | ||
| export async function scheduleTx({ api }: { api: ApiPromise }, call: string, at = undefined, origin = 'Root') { | ||
| const number = at ? at : (await api.rpc.chain.getHeader()).number.toNumber() |
There was a problem hiding this comment.
no, if at is set to block 0. Because ? checks for truthiness and 0 is falsy. ?? checks for null & undefined only.
integration-tests/chopsticks/src/tests/switchPallet/pause/switchEkilts/index.test.ts
Outdated
Show resolved
Hide resolved
rflechtner
reviewed
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3252
This pull request introduces several enhancements and updates to the integration tests for the Chopsticks project. The changes include updates to environment variables, workflow configurations, dependencies, and the addition of new helper functions and documentation. Below are the most important changes grouped by theme:
Workflow and Environment Configuration:
.github/workflows/check-code.ymlto include block numbers and WASM overrides for different networks. Added a setup for Cargo cache to improve build efficiency. [1] [2] [3].env-examplefile to include new mandatory and optional environment variables for the tests.Documentation:
README.mdfor the Chopsticks integration tests, detailing setup instructions, environment variables, running tests, code style, adding new test cases, debugging, and recommended VS Code extensions.CLI and Command Enhancements:
src/cli.tsto manage Chopsticks instances with commands for spinning up networks, scheduling transactions, and showing state transitions.src/command/index.ts,src/command/network.ts,src/command/scheduleTx.ts, andsrc/command/stateTransition.ts. [1] [2] [3] [4]