j #1
Closed
j #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GP. (#262) * Changes to regression test files for recent changes to RRTMG and RRTMGP. * Removed redundant importing of kind_phys in physics * add units to index_for_diagnostic_printout metadata * Replace iovr_{lw,sw} with iovr for HWRF regression tests * Bugfix in GP sampling routines. * Increase number of nodes for test fv3_ccpp_gocart_clm on Cheyenne Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>
* bring GFS.v16 code changes back to develop branch * update upp lib in hera module * use test hpc stack lib * update upp lib in fv3 for cmake * update post control files * update upp lib in hpcstack on hera, orion and dell and in nceplibs on cray * add change in fv3 dycore #35 * remove duplicate read_data in fms_mod in external_ic.F90 Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>
* If ufs.cpld.cpl.r.* files do not reproduce, try nccmp * Modify/add to run cpld 35d bmark tests * Fix nccmp implementation. Fix a bug for 35d tests * Use env var NCCMP * Add hera.intel to rt_35 and rt_wave_35d * Use which to find nccmp path. Apply nccmp to all files that fail cmp. Fix a bug in fv3_ccpp_wrtGauss_netcdf_parallel * Change compare method from nccmp to compare_ncfile.py * Netcdf compare changes on Hera; skip-ci * Netcdf compare changes on WCOSS Dell P3; skip-ci * Modify comopare_ncfile.py * Netcdf compare changes on wcoss cray * Implement Dusan's ecflow fix #273 * Move miniconda3 to emc.nemspara on Hera and Orion. Minor change in default_vars.sh
* sync fv3 feature branch * Regression test passed on Hera and Orion, WCOSS_dell, WCOSS_cray, Hera_gnu * Update for FV3 to point to the develop branch
…, updates to other GSL physics (#297) - add unified gravity wave drag (called unified ugwp) that combines the UGWP v1 with the GSL drag suite - replace high-resolution SAR (standalone regional) regression test with 25km SAR regression test - update submodule pointer for fv3atm for the changes described in the associated PRs listed below - add `rt_ccpp_dev.conf` that contains the developmental CCPP tests used by GSL and DTC (so that folks are aware of what is tested and how by DTC and GSL, in addition to what is in `rt.conf` and `rt_gnu.conf`) - turn on calls to `gcycle`/`sfcsub` for RUC LSM - regression test configuration scripts for MYNN surface layer - add `fv3_debug` modules for cheyenne.intel and cheyenne.gnu (per request from @DeniseWorthen) - bugfix in `rt.sh` to copy two missing input directories `fv3_regional_quilt_netcdf_parallel` and `fv3_stretched_nest_debug` when creating new baselines using `rt.sh -c` - enable regression testing on Gaea with Intel using the current hpc-stack-nco installation, can now use ecflow - update of CI tests and small bugfix when comparing results using `tests/compare_ncfile.py` from @MinsukJi-NOAA (see #299 for details) - note, the update to `tests/compare_ncfile.py` had to be reverted Co-authored-by: DomHeinzeller <58610420+DomHeinzeller@users.noreply.github.com> Co-authored-by: samuel.trahan <Samuel.Trahan@noaa.gov> Co-authored-by: hannah barnes <hannah.barnes@noaa.gov> Co-authored-by: Michael Toy <michael.toy@noaa.gov> Co-authored-by: Samuel Trahan (NOAA contractor) <39415369+SamuelTrahanNOAA@users.noreply.github.com> Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov>
Fix to stochastic_physics_wrapper to allow for random patterns to update at a longer time-step than model Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>
…d in restarting with frac_grid=T (#304) Update the modulefile for jet.intel to enable UPP v10.0.0. The hpc-stack v1.0.0 pre-release is used for this. Small changes are made to tests.rt.sh for jet.intel and gaea.intel (consistency with other platforms). The submodule pointer update for fv3atm addresses bugs in the ufs-weather-model with frac_grid=T and GFDL microphysics, and with restarting the model when frac_grid=T (from @shansun6 and @SMoorthi-emc).
* point MOM6 to new branch which corresponding to GFDL 20201022 commit * modify fms_files.cmake and mom6_files.cmake to reflect changes in MOM6 code as this version of MOM6 contains some file deletion, new files being added and renaming of files * manually set MOM6 parameters in order to retain origonal results for 0.25x0.25 resolution * update MOM6 to include Bugfix for mom6solo to be built * modify compile.sh to allow mom6solo compiling * modify MOM_input_template for all resolutions based on GFDL MOM6-example main branch update on 20201022 * change executable permissions for CMakeLists.txt * chmod 644 to 6 files Dom pointed out * chmod for CMakeLists.txt and tests/compile.sh * change baseline directpory to 20201202 in rt.sh
) *Updates CICE to most recent develop branch of NOAA-EMC * Sets n_aero (number of aerosols) in ice_in_template to 0. * removes trailing whitespace from ice_in * moves regression test input outside baseline directory (ufs-weather PR #312) Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
JustinPerket
pushed a commit
that referenced
this pull request
Aug 16, 2021
…y#524) * point to Jun fv3atm personal fork * add CDEPS submodule * add building instructions * fix issues that came from building * builds CDEPS targets * missed w3nco dep * cleanup use of FoX and remove redundant library links in components * Add 3 files generated by genf90.pl to the CDEPS-interface/ufs directory. (#1) * remove dependency on genf90.pl for CDEPS/share * remove FoX (#2) remove FoX dependency building and use ESMF Config instead. Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: BinLi-NOAA <bin.li@noaa.gov> Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?
Are any library updates included in this PR (modulefiles etc.)?
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs