feat: add onReady property #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipiash
suggested changes
Jan 25, 2021
dipiash
approved these changes
Jan 25, 2021
Jungwoo-An
reviewed
Jan 25, 2021
There was a problem hiding this comment.
Wow! First-time contributor! 🤝
This proposal is very good. If you don't mind, can you update README.md?
.gitignore
Outdated
| @@ -1,2 +1,3 @@ | |||
| node_modules | |||
| .rpt2_cache | |||
| .idea | |||
There was a problem hiding this comment.
Please delete this line. .idea directory is required only InteliJ users.
There was a problem hiding this comment.
Sure, I deleted .idea and updated info in README.md.
Thank you for reviewing this PR.
Jungwoo-An
approved these changes
Jan 26, 2021
| @@ -60,6 +60,7 @@ Allow all options of [editor-js](https://github.com/codex-team/editor.js/blob/ma | |||
| | enableReInitialize | Boolean | Change editor-js data when componentDidUpdate | | |||
| | onChange | (api: API, newData: OutputData) => void | Fires when something changed in DOM | | |||
| | onCompareBlocks | (newBlocks?: OutputData['blocks'], oldBlocks?: OutputData['blocks']) => boolean | Use to avoid Infinite update when enableReInitialize used with onChange ([Recommended Library](https://github.com/FormidableLabs/react-fast-compare)) | | |||
| | onReady | (instance?: EditorJS) => void | Use to execute callback when editor-js instance has initialized | | |||
Jungwoo-An
pushed a commit
that referenced
this pull request
Jan 27, 2021
## [1.9.0](1.8.0...1.9.0) (2021-01-27) ### Features * add onReady property ([#91](#91)) ([d243539](d243539))
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Thank you for this library - it helps me a lot!
I guess it would be great feature to add "onReady" property - to have possibility to use editor modifiactions callback.
https://editorjs.io/configuration#editor-modifications-callback
It can be useful with other editorjs plugins. (for example this one - https://github.com/kommitters/editorjs-undo)