Define IndexStyle for AbstractWeights
#823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since indexing into a weight vector in turn indexes into its vector of
values, the optimal index style for a weight vector is the same as that
of its values. Currently it uses the default `IndexCartesian` since no
more specific `IndexStyle` method is defined.
Before this commit:
```
julia> eachindex(1:3, weights(1:3))
3-element CartesianIndices{1, Tuple{Base.OneTo{Int64}}}:
CartesianIndex(1,)
CartesianIndex(2,)
CartesianIndex(3,)
```
After:
```
julia> eachindex(1:3, weights(1:3))
Base.OneTo(3)
```
nalimilan
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since indexing into a weight vector in turn indexes into its vector of values, the optimal index style for a weight vector is the same as that of its values. Currently it uses the default
IndexCartesiansince no more specificIndexStylemethod is defined.Before this commit:
After: