-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation mistake?: implementation of varcorrection
is different from the comment in weights.jl
#784
Comments
The docstring says "where |
The number |
nalimilan
added a commit
that referenced
this issue
Apr 7, 2022
This didn't match the implementation. Fixes #784.
Ah sorry I had misunderstood your comment. This is indeed a typo (probably a copy/paste). See #785. |
Thank you for your quick responce! I close this issue. |
nalimilan
added a commit
that referenced
this issue
Apr 7, 2022
This didn't match the implementation. Fixes #784.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The problem is here.
The comment say that we get
\frac{n}{n - 1}
ifcorrected=true
, but the implementation is(1 / (w.len - 1))
. Which is true? Implementation is right, I think.The text was updated successfully, but these errors were encountered: