Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support transformed response for predict #614

Merged
merged 7 commits into from
May 17, 2022
Merged

support transformed response for predict #614

merged 7 commits into from
May 17, 2022

Conversation

palday
Copy link
Member

@palday palday commented May 17, 2022

closes #613

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

palday and others added 3 commits May 17, 2022 11:45
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #614 (f777414) into main (cf3a6f1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head f777414 differs from pull request most recent head 56c049e. Consider uploading reports for the commit 56c049e to get more accurate results

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   94.16%   94.19%   +0.03%     
==========================================
  Files          29       29              
  Lines        2757     2757              
==========================================
+ Hits         2596     2597       +1     
+ Misses        161      160       -1     
Impacted Files Coverage Δ
src/predict.jl 98.30% <100.00%> (ø)
src/linearmixedmodel.jl 98.24% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf3a6f1...56c049e. Read the comment docs.

@palday palday requested a review from kleinschmidt May 17, 2022 17:05
@palday palday merged commit 3122b72 into main May 17, 2022
@palday palday deleted the pa/predsym branch May 17, 2022 23:57
palday added a commit that referenced this pull request May 17, 2022
* support transformed response for predict

* NEWS and patch bump

* more tests

* remove some progress bars in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taking Symbol of LHS of transformed column triggering error
2 participants