Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save losses from each fold in the final CV path #61

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Conversation

JackDunnNZ
Copy link
Collaborator

This gives the ability for downstream users to determine the best fit on the path using whichever metric they want, rather than arbitrarily limiting to just mean and std

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #61 (12f88e2) into master (bc737cf) will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   92.85%   93.21%   +0.35%     
==========================================
  Files           3        3              
  Lines         434      457      +23     
==========================================
+ Hits          403      426      +23     
  Misses         31       31              
Impacted Files Coverage Δ
src/GLMNet.jl 94.79% <100.00%> (+0.39%) ⬆️
src/Multinomial.jl 93.00% <0.00%> (+0.14%) ⬆️
src/CoxNet.jl 88.63% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc737cf...12f88e2. Read the comment docs.

@JackDunnNZ JackDunnNZ merged commit 4b87218 into master Aug 30, 2021
@JackDunnNZ JackDunnNZ deleted the jd/save_losses branch June 6, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants