-
Notifications
You must be signed in to change notification settings - Fork 40
Add support for creating correlated variables from a covariance or correlation matrix #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do you want to keep the backwards compatibility to version 1.0? If yes, I will have to find some compromises regarding readability/speed with the code. |
I haven't looked into the details of the implementation, but this is awesome! I'm happy to drop support for older versions of Julia, what would be the first one needed as things are now? |
I will add the corresponding usage documentation and a few examples in the coming days as soon as I find some more time. |
7b1084b
to
57a6246
Compare
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 95.45% 95.63% +0.18%
==========================================
Files 12 12
Lines 726 756 +30
==========================================
+ Hits 693 723 +30
Misses 33 33
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
57a6246
to
7c8a939
Compare
I have added documentation for both, could you check if it fits your expectation? Also, are you happy with the function names? There are existing functions in |
BTW, this PR solves the only point in the TODO list Measurements.jl/docs/src/todo.md Lines 8 to 12 in d417519
|
Thanks for your comments, I will fix them. What is your opinion on extending the functions in Statistics named |
cbf6a6b
to
b319b9f
Compare
b319b9f
to
45db0d4
Compare
Thanks a lot for this nice contribution, much appreciated and awaited! |
This PR adds four new functions:
to calculate the covariance matrix from a vector of measurements,
to calculate the correlation matrix, and
and
to create correlated variables from a covariance and correlation matrix respectively.
The algorithms are taken from the python package
uncertatinties
. If that is not okay, please tell me.If there are issues with code styling, or if something is missing, I am happy to fix or add it.