Add mlir-jl-tblgen #7951
Merged
Add mlir-jl-tblgen #7951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
commented
Jan 14, 2024
| # Dependencies that must be installed before this package can be built | ||
| llvm_name = llvm_assertions ? "LLVM_full_assert_jll" : "LLVM_full_jll" | ||
| dependencies = [ | ||
| BuildDependency(PackageSpec(name=llvm_name, version=llvm_version)) |
There was a problem hiding this comment.
Do we need to add MLIR_jll here?
There was a problem hiding this comment.
The MLIR lib and headers are already in LLVM_full_jll, so... nope
vchuravy
commented
Jan 14, 2024
mofeing
reviewed
Jan 14, 2024
|
|
||
| # Bash recipe for building across all platforms | ||
| script = raw""" | ||
| cd MLIR.jl/deps/tblgen |
There was a problem hiding this comment.
Shouldn't we move it to another dir? We can do it later, just an opinion
There was a problem hiding this comment.
I don't think there is a need for it, we could make it follow the structure a bit more, but right now that seems over the top for two cc files.
This was referenced Jan 15, 2024
giordano
reviewed
Jan 15, 2024
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
grasph
pushed a commit
to Moelf/Yggdrasil
that referenced
this pull request
Jul 1, 2024
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.