-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GDAL] Add zstd and webp drivers #1941
Conversation
More food for JuliaGeo/GDAL.jl#65. Failing builds are due to hash mismatches or failed downloads. |
I believe only FreeBSD is still failing. Something something libstdc++.so.6 not found. |
G/GDAL/build_tarballs.jl
Outdated
@@ -35,6 +35,7 @@ elif [[ "${target}" == *-linux-* ]]; then | |||
fi | |||
autoreconf -vi | |||
fi | |||
export LDFLAGS="$LDFLAGS -lstdc++" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look like a good idea, especially for macOS and FreeBSD. Why did you need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking. All linux builds failed without it, but it seems I moved it slightly to high, will move it into the linux check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see we are already using it for other libraries when building for linux platforms, this is a bit borked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this caused FreeBSD to fail, now works :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we don't use GCC for macOS and FreeBSD by default, hence no libstdc++
Btw, thanks for keeping a very close eye on the failing builds, restarting where necessary. 🥇 |
Good to go? |
I'd say yes! @visr? |
Great, thanks for working on this! I just opened a few random logs like this and see what we want to see:
So this is good to go. @evetion would be great if you could update https://github.com/JuliaGeo/GDAL.jl/blob/ac27d0f35569a560abd813f217d90beaaf1a5f76/test/drivers.jl correspondingly after this is merged, such that we can test regressions in the build. |
Maybe it'd be good to add checks similar to these: Yggdrasil/G/GDAL/build_tarballs.jl Lines 52 to 55 in 14361cc
|
Done. And, for good measure, also tried to add a Postgres driver. Let's see how that works out. |
Will do after this is merged. 👍 |
Ok, it seems PostgreSQL is not as easy as the other drivers, I'll do that in another PR. It seems the builds failed with it failing to find the header files, such as here. Sorry for the noise. |
@giordano This is ready to merge, only the CI needs a little nudge. |
Instead of upgrading, let's broaden some drivers. Had to enable -lstdc++, not sure if it's needed on other platforms than linux.