Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Faiss] Replaced MKL and OpenBLAS with libblastrampoline #10352

Merged
merged 7 commits into from
Jan 30, 2025

Conversation

stemann
Copy link
Contributor

@stemann stemann commented Jan 27, 2025

Due to issue with linking with MKL: #8572 (comment)

Also, removes the need to build with a newer GCC (than v7) wrt. OpenBLAS on PowerPC64LE.

Due to issue with linking with MKL: JuliaPackaging#8572 (comment)

Also, removes the need to build with a newer GCC (than v7) wrt. OpenBLAS on PowerPC64LE.
@stemann stemann marked this pull request as draft January 27, 2025 09:15
@stemann stemann marked this pull request as ready for review January 28, 2025 10:24
@stemann stemann marked this pull request as draft January 28, 2025 10:33
@stemann stemann marked this pull request as ready for review January 28, 2025 10:37
@stemann stemann requested a review from imciner2 January 28, 2025 11:21
# Valid values are "generic", "avx2", "avx512", "sve".
option(FAISS_OPT_LEVEL "" "generic")
option(FAISS_ENABLE_GPU "Enable support for GPU indexes." ON)
+option(FAISS_ENABLE_MKL "Enable MKL." ON)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stemann stemann marked this pull request as draft January 28, 2025 12:22
@stemann stemann marked this pull request as ready for review January 28, 2025 12:22
@giordano giordano merged commit 334df79 into JuliaPackaging:master Jan 30, 2025
31 checks passed
@stemann stemann deleted the feature/faiss_mkl branch January 30, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants