Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Arpack tarball to include symlink fixes #82

Merged
merged 3 commits into from
Dec 3, 2019

Conversation

staticfloat
Copy link
Member

This upgrades the libarpack download to avoid windows symlink issues.

@coveralls
Copy link

coveralls commented Dec 3, 2019

Pull Request Test Coverage Report for Build 143

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.116%

Totals Coverage Status
Change from base Build 127: 0.0%
Covered Lines: 183
Relevant Lines: 215

💛 - Coveralls

@andreasnoack
Copy link
Member

It looks like there is an issue with the Mac binaries

@staticfloat
Copy link
Member Author

Yep; even though JLL packages don't have the same issue, since this is not using JLL packages, I needed to reintroduce the install_name_tool workaround. Making its way through in JuliaPackaging/Yggdrasil#256

@staticfloat staticfloat force-pushed the sf/update_arpack_tarball branch from 0610d76 to 5324164 Compare December 3, 2019 18:06
@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   85.11%   85.11%           
=======================================
  Files           2        2           
  Lines         215      215           
=======================================
  Hits          183      183           
  Misses         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53e0427...826f816. Read the comment docs.

@staticfloat staticfloat force-pushed the sf/update_arpack_tarball branch 2 times, most recently from f8ec4b3 to 318eac4 Compare December 3, 2019 18:20
@staticfloat staticfloat force-pushed the sf/update_arpack_tarball branch from 318eac4 to 826f816 Compare December 3, 2019 20:49
@staticfloat
Copy link
Member Author

Alright, third time's a charm. This one should work. Finally.

@staticfloat staticfloat merged commit 558952f into master Dec 3, 2019
@staticfloat staticfloat deleted the sf/update_arpack_tarball branch December 3, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants