OSX: Add both RPATH entries to julia, don't overwrite
#21134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See 30ba746#commitcomment-21430419 for more details
ararslan
approved these changes
Mar 22, 2017
tkelman
pushed a commit
that referenced
this pull request
May 2, 2017
See 30ba746#commitcomment-21430419 for more details (cherry picked from commit 7ce4925) ref #21134
tkelman
pushed a commit
that referenced
this pull request
May 3, 2017
See 30ba746#commitcomment-21430419 for more details (cherry picked from commit 7ce4925) ref #21134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially, we were overwriting our first
RPATHentry with our second, instead of adding them together. This didn't actually break anything, but was a little bit of a surprise for me when I was trying to debug something.