Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Vec3f0 with Vec3f, FRect3D with Rect3f #74

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

knuesel
Copy link
Contributor

@knuesel knuesel commented Jul 20, 2021

This switches to new GeometryBasics type names from JuliaGeometry/GeometryBasics.jl#97.

@knuesel
Copy link
Contributor Author

knuesel commented Jul 21, 2021

This should be ready for merge now.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #74 (5ee9466) into master (fe89c97) will not change coverage.
The diff coverage is 90.90%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files           8        8           
  Lines         412      412           
=======================================
  Hits          385      385           
  Misses         27       27           
Impacted Files Coverage Δ
src/MeshIO.jl 100.00% <ø> (ø)
src/io/obj.jl 96.77% <75.00%> (ø)
src/io/2dm.jl 89.65% <100.00%> (ø)
src/io/msh.jl 96.77% <100.00%> (ø)
src/io/off.jl 100.00% <100.00%> (ø)
src/io/ply.jl 100.00% <100.00%> (ø)
src/io/stl.jl 96.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1565236...5ee9466. Read the comment docs.

@SimonDanisch SimonDanisch merged commit 97ce3af into JuliaIO:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants