Update a few cases where array indices are assumed #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
==========================================
- Coverage 94.33% 94.09% -0.24%
==========================================
Files 9 9
Lines 1270 1271 +1
==========================================
- Hits 1198 1196 -2
- Misses 72 75 +3
Continue to review full report at Codecov.
|
johnnychen94
approved these changes
May 22, 2022
|
@johnnychen94 should this be merged too? |
|
Hooray! |
johnnychen94
pushed a commit
that referenced
this pull request
Dec 15, 2022
* Since `seed::AbstractVector`, don't assume array index * Replace `1:length` with `eachindex` in for loop * Fix index calculation in distinguishable_colors
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may not be everything, but a few simple cases that were easy to update