Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TagBot.yml #449

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Update TagBot.yml #449

merged 1 commit into from
Dec 23, 2020

Conversation

kimikage
Copy link
Collaborator

@kimikage kimikage commented Nov 6, 2020

cf. https://discourse.julialang.org/t/ann-required-updates-to-tagbot-yml/49249

// Sorry for the messy branch name as I thought I had created the branch in my fork.

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #449 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #449   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files          10       10           
  Lines         952      952           
=======================================
  Hits          881      881           
  Misses         71       71           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd9788b...e0aa636. Read the comment docs.

@kimikage
Copy link
Collaborator Author

kimikage commented Nov 6, 2020

BTW, I think the v0.12.4 documentation will be permanently missing if we don't run the generation manually before the next tag release. There should be no documentation changes between v0.12.3 and v0.12.4, so we might just need to manually copy the documentation for v0.12.3.

@johnnychen94
Copy link
Member

Probably it's better for @timholy to do massive update via direct commit to all related repos.

@timholy
Copy link
Member

timholy commented Nov 9, 2020

That's my intention. I'm still digging out from some deadlines last week and wanting to push one or two more things over the finish line for the 1.6 feature freeze, but I'll do this fairly soon.

@kimikage
Copy link
Collaborator Author

kimikage commented Dec 1, 2020

I saw that @timholy executed the MassInstallAction for packages under his personal repositories. 😄
I am currently thinking of merging this single PR in order to release PR #451 as v0.12.5.

BTW, after the updating of TagBot, "Fixing broken release deployments" seems to be available for v0.12.4 documentation.
https://juliadocs.github.io/Documenter.jl/stable/man/hosting/#Documentation-Versions

@kimikage
Copy link
Collaborator Author

I will update only Colors.jl manually.

@kimikage kimikage merged commit 724b92d into master Dec 23, 2020
@kimikage kimikage deleted the tagbot branch December 23, 2020 13:23
@kimikage
Copy link
Collaborator Author

Also, I generated the docs for v0.12.4 with the TagBot action: http://juliagraphics.github.io/Colors.jl/v0.12.4/
So, the permission setting (ssh: ${{ secrets.TAGBOT }}) works fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants