-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support range(start, stop; kwargs...) #337
Support range(start, stop; kwargs...) #337
Conversation
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 62.66% 70.35% +7.68%
==========================================
Files 9 10 +1
Lines 616 742 +126
==========================================
+ Hits 386 522 +136
+ Misses 230 220 -10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 62.66% 70.48% +7.82%
==========================================
Files 9 10 +1
Lines 616 742 +126
==========================================
+ Hits 386 523 +137
+ Misses 230 219 -11
Continue to review full report at Codecov.
|
bump |
Good to go? |
It looks good to me. Without this patch, it would raise some strange error message. julia> range(Gray(0), Gray(1), length=11)
11-element LinRange{Gray{Normed{UInt8,8}}}:
Error showing value of type LinRange{Gray{Normed{UInt8,8}}}:
ERROR: MethodError: no method matching *(::Float64, ::Gray{Normed{UInt8,8}})
Closest candidates are:
*(::Any, ::Any, ::Any, ::Any...) at operators.jl:529
*(::Float64, ::Float64) at float.jl:399
*(::AbstractFloat, ::Bool) at bool.jl:112
...
Unfortunately, @timholy is quite busy on his daily work recently; you might need to wait for a while until he finds some time to merge this. |
Alright, no worries. Thanks for the info! |
From Julia 1.1 on,
range(start, stop; kwargs...)
is supported complementary torange(start; stop, kwargs...)
. This PR adds the former method forColorant
s.