Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure SSH key for TagBot and optionally for CompatHelper #443

Closed
johnnychen94 opened this issue Sep 18, 2020 · 1 comment · Fixed by #444
Closed

configure SSH key for TagBot and optionally for CompatHelper #443

johnnychen94 opened this issue Sep 18, 2020 · 1 comment · Fixed by #444

Comments

@johnnychen94
Copy link
Member

johnnychen94 commented Sep 18, 2020

I tried to not notify anyone with a direct commit c88f062 but it doesn't work...

Here's the motivation:

One GitHub action could not trigger another GitHub action if only configured with token: ${{ secrets.GITHUB_TOKEN }}. This limitation means, PR created by CompatHelper could not trigger the unit test, and release/tag created by tagbot could trigger the docs CI, which is switched to GH in #433 .

The ssh key for tagbot seems a necessary step. Though the ssh key for compat helper could be skipped given that we still need to manually check the versions even if the unit test runs.

For TagBot, the quick command to generate ssh key:

ssh-keygen -t rsa -b 4096 -C "email@example.com" -f tagbot

then copy tagbot.pub as keys and tagbot as secrets (let's say with name "TagBot"). A commit like JuliaImages/ImageEdgeDetection.jl@bd6515a should then set things done. (Haven't checked it because there's no new releases...)

References:

cc: @cormullion @timholy

johnnychen94 added a commit to JuliaImages/ImageEdgeDetection.jl that referenced this issue Sep 18, 2020
To let tagbot trigger docs CI

More details can be found in JuliaGraphics/Colors.jl#443
timholy added a commit that referenced this issue Sep 19, 2020
@timholy
Copy link
Member

timholy commented Sep 19, 2020

Thanks for the hand-holding, really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants