Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy more constructors from type doc to getting started #3323

Merged
merged 6 commits into from
Apr 30, 2023

Conversation

xgdgsc
Copy link
Contributor

@xgdgsc xgdgsc commented Apr 28, 2023

I feel those constructors are used frequently and hard to find if not in getting started doc. Would it be better to copy them here?

And I feel the Note section on top a bit long and useless in a getting started doc. I think the display is ommited is already obvious from the output. Might be better to move that out to another advanced topic page.

@bkamins
Copy link
Member

bkamins commented Apr 28, 2023

Thank you. I patched your proposal and will merge it once CI passess.

Ragarding the Note. Indeed it needs to be moved. @ronisbr is working on update of the "displaying" section of the manual and it should go there. (in the past having this note here was crucial, after recent releases it is less important as by default we print quite wide tables nicely by default)

@bkamins bkamins added the doc label Apr 28, 2023
@bkamins bkamins added this to the 1.6 milestone Apr 28, 2023
@ronisbr
Copy link
Member

ronisbr commented Apr 28, 2023

Yes! I really need to write that section. Sorry about the delay. I had some major problems and only in the past month I could start a required revamp of SatelliteToolbox.jl. As soon as I finish, I will write this section and closes one or two issues that are opened regarding display.

@bkamins bkamins merged commit 3909f13 into JuliaData:main Apr 30, 2023
@bkamins
Copy link
Member

bkamins commented Apr 30, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants