Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some contributions guide #2723

Merged
merged 7 commits into from
Apr 18, 2021
Merged

Conversation

RohitRathore1
Copy link
Contributor

No description provided.

@bkamins
Copy link
Member

bkamins commented Apr 17, 2021

Ah - and you might add that if a PR is not finished yet and SHOULD NOT be reviewed yet then it should be opened as DRAFT (in this way I will know I can ignore such PR until it is made non-draft or the author asks for a review).

@bkamins
Copy link
Member

bkamins commented Apr 17, 2021

Also maybe mention somewhere (if it is not mentioned yet) that all PRs and issues should be made against the main branch not against the current release as this is one of the most common problems.

@RohitRathore1
Copy link
Contributor Author

Also maybe mention somewhere (if it is not mentioned yet) that all PRs and issues should be made against the main branch not against the current release as this is one of the most common problems.

Ohh, okay. I am making the required changes. Thanks for reviewing

@bkamins
Copy link
Member

bkamins commented Apr 17, 2021

Code organization comments before I review again:

  1. Can you please add line breaks to very long lines?
  2. Ca you please use punctuation at the end of lines (in particular when making bulleted lists)

@RohitRathore1
Copy link
Contributor Author

Made required changes.

@bkamins bkamins requested a review from nalimilan April 17, 2021 18:41
@RohitRathore1
Copy link
Contributor Author

Fixed errors which were requested by @nalimilan

@bkamins
Copy link
Member

bkamins commented Apr 18, 2021

For a reference: you can assume that @nalimilan noticed that. We need to wait for his approval. In general expect that things take several days when working on PRs (so this means that it is good to have several things in parallel in the pipeline if you can spend more time on working on the package).

Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me if it's OK for you @bkamins.

@bkamins
Copy link
Member

bkamins commented Apr 18, 2021

Thank you!

@bkamins bkamins merged commit 596a7b1 into JuliaData:main Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants