-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added some contributions guide #2723
Conversation
Ah - and you might add that if a PR is not finished yet and SHOULD NOT be reviewed yet then it should be opened as DRAFT (in this way I will know I can ignore such PR until it is made non-draft or the author asks for a review). |
Also maybe mention somewhere (if it is not mentioned yet) that all PRs and issues should be made against the |
Ohh, okay. I am making the required changes. Thanks for reviewing |
Code organization comments before I review again:
|
Made required changes. |
Fixed errors which were requested by @nalimilan |
For a reference: you can assume that @nalimilan noticed that. We need to wait for his approval. In general expect that things take several days when working on PRs (so this means that it is good to have several things in parallel in the pipeline if you can spend more time on working on the package). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me if it's OK for you @bkamins.
Thank you! |
No description provided.