-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable multithreading with several operations in combine/select/transform #2574
Merged
Merged
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
6594e78
Spawn one task per operation
nalimilan 8e29048
Fix handling of idx_agg and order of columns
nalimilan 2ca83f9
Use threading in another loop
nalimilan b9eb025
Remove redundant idx handling
nalimilan 487fce7
Support Julia 1.0
nalimilan 78106ea
tmp
nalimilan 97090f4
idx_agg can't be nothing
nalimilan 801e54e
Use default exception handling
nalimilan 688e7c3
Add test
nalimilan a3dd7fd
Add @sync
nalimilan 4a12320
Fix exception type
nalimilan adf35bf
More robust exception handling
nalimilan aed32c4
Fix Julia 1.0
nalimilan e442ce5
Typo
nalimilan 6d96c2a
Add `@spawn` test
nalimilan 38b2511
Call GC.safepoint every 100_000 rows
nalimilan 542cd1c
Review fixes
nalimilan fec4aae
Merge branch 'main' into nl/threadedops
nalimilan 4ceddf5
Add mention in the manual
nalimilan a0ce364
Fix Julia 1.0
nalimilan c7b3cee
Add comment
nalimilan e1a0222
Improve docs
nalimilan 76a7a21
Use multiple threads on CI, warn if not
nalimilan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add that this means that the transformation functions passed should not modify the same state of the Julia program?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I've also mentioned that this may be extended in the future so that people are not caught by surprise.