Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure by isa Function or a vector of functions #2501

Merged
merged 2 commits into from
Oct 29, 2020
Merged

make sure by isa Function or a vector of functions #2501

merged 2 commits into from
Oct 29, 2020

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Oct 27, 2020

Fixes #2500

@bkamins bkamins added the bug label Oct 27, 2020
@bkamins bkamins added this to the 1.0 milestone Oct 27, 2020
@bkamins
Copy link
Member Author

bkamins commented Oct 29, 2020

@pdeffebach - you can approve if you are OK with the changes. Thank you!

@bkamins bkamins merged commit e160eb7 into master Oct 29, 2020
@bkamins bkamins deleted the bkamins-patch-1 branch October 29, 2020 13:40
@bkamins
Copy link
Member Author

bkamins commented Oct 29, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdeffebach pdeffebach pdeffebach approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

sort with by accepts tuples still
2 participants
@bkamins @pdeffebach