Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deprecated example in the docs for innerjoin #2320

Merged
merged 1 commit into from
Jul 22, 2020
Merged

fix deprecated example in the docs for innerjoin #2320

merged 1 commit into from
Jul 22, 2020

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Jul 20, 2020

No description provided.

@bkamins bkamins added this to the 1.0 milestone Jul 20, 2020
@bkamins
Copy link
Member Author

bkamins commented Jul 22, 2020

only coverage fails here

@bkamins bkamins requested a review from quinnj July 22, 2020 09:38
@bkamins
Copy link
Member Author

bkamins commented Jul 22, 2020

@quinnj can you please have a look at it as @nalimilan is OOO and it is an easy fix. Thank you!

nalimilan
nalimilan approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I check my messages just enough to approve. ;-)

@bkamins
Copy link
Member Author

bkamins commented Jul 22, 2020

Thank you!

@bkamins bkamins merged commit 7a73a9e into master Jul 22, 2020
@bkamins bkamins deleted the bkamins-docs-patch branch July 22, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
backport doc
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bkamins @nalimilan @quinnj