-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DataFrame constructors allowing NTuple and collection of Pair-s #1717
Conversation
I have added a constructor with collection of pairs also (without a deprecation - but I can add it if we found we need to). |
@nalimilan this should be good to have a look at. No rush. |
Is it necessary to have DataFrames constructors like this? Why not just off-load everything to Tables.jl? |
The |
Thanks for the explanation! Wow there are a lot of edge cases. Would it be better to throw errors due to ambiguity and then point the user towards something more specific? |
All the functions for tuples are one-liners, so it is less code to implement them than to produce a proper deprecation. |
I agree we should drop methods mixing vectors and tuples. It's already complex enough to cover all reasonable cases... |
OK - removed |
Following #1599 I have added 3 new constructors (allowing a Tuple for columns and for names - for completeness).