-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section headings and row-by-row construction example #1416
Conversation
I'm not sure we should recommend creating data frames row by row, as it's really inefficient. At least we should explain how to create it by columns first. Can you also fix the typography (code in backticks, spaces in "data frame", consistency in case, etc.)? |
Here is what I am thinking:
Now let me detail (what I think) the use case for each is: All at onceThis is basically only for if you are loading data generated else-where. Row by RowTo me, row by row is the only way anyone ever would create a dataframe live. While appending a row is slow it is vanishingly small compared to the simulation time. The possible exception to this being the only way, Column by ColumnThis isn't actually used to construct a dataframe.
Maybe, a possible case where is is used to actually construct a dataframe might be if you are pulling columns out of a database, based on the existing df column (or Vector) of keys. |
I still disagree. The presentation logically starts by presenting the main |
Alright, I've said my piece and failed to convince you, so fair enough. |
Thanks. Can you also fix the spacing and syntax? |
I think this is all good now? |
Sorry, there are still lots of typos and of inconsistencies in casing and in the way |
I'll give it another check over. |
bump |
What do I need to do? |
There are still typos, weird uses of semicolons, inconsistent casing in headings and missing blank lines after headings. Plus lines should be under 92 characters. |
Hopefully I've got them all now
Ok, I've made all the heading start every words with upper-case.
Fixed.
I was under the impression that that convention is not being followed for this file. I feel like line-breaking the whole file can be its own PR. |
Thanks. |
I think it is easier to navigate with section headings.
And the row-by-row construction is something I always forget how to do.
(and I think more useful than column by column)