avoid allocation when negating BitArray in dropmissing! (#2497)

JuliaData · Oct 23, 2020 · 40c368d · 40c368d
1 parent e07b08d
commit 40c368d
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/abstractdataframe/abstractdataframe.jl b/src/abstractdataframe/abstractdataframe.jl
@@ -911,7 +911,9 @@ julia> dropmissing!(df3, [:x, :y])
 function dropmissing!(df::AbstractDataFrame,
                       cols::Union{ColumnIndex, MultiColumnIndex}=:;
                       disallowmissing::Bool=true)
-    delete!(df, (!).(completecases(df, cols)))
+    inds = completecases(df, cols)                                  
+    inds .= .!(inds)
+    delete!(df, inds)
     disallowmissing && disallowmissing!(df, cols)
     df
 end