Update ob_start signature #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I do something for the failing check @isfedorov ? I'm not sure to understand the error. |
isfedorov
requested changes
Jan 27, 2025
standard/standard_8.php
Outdated
| @@ -143,7 +143,7 @@ function metaphone(string $string, int $max_phonemes = 0) {} | |||
| /** | |||
| * Turn on output buffering | |||
| * @link https://php.net/manual/en/function.ob-start.php | |||
| * @param callable $callback [optional] <p> | |||
| * @param callable|null $callback [optional] <p> | |||
There was a problem hiding this comment.
@VincentLanglet since you have added null as a default value in signature, [optional] can be removed here. It's clear that parameter is optional based on signature
|
@VincentLanglet the failure is related to not supported yet php-cs-fixer + PHP 8.4. You may ignore it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf https://www.php.net/manual/en/function.ob-start.php
ob_start is