Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing barriers in litmus test runner #25

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

eupp
Copy link
Member

@eupp eupp commented Jan 10, 2025

No description provided.

Signed-off-by: Evgeniy Moiseenko <evg.moiseenko94@gmail.com>
@eupp eupp requested a review from DLochmelis33 January 10, 2025 12:05
@eupp eupp changed the base branch from main to development January 10, 2025 12:06
Copy link
Collaborator

@DLochmelis33 DLochmelis33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the second barrier is necessary, but better safe than sorry I guess

@eupp
Copy link
Member Author

eupp commented Jan 17, 2025

Not sure if the second barrier is necessary, but better safe than sorry I guess

I guess it is necessary, because we want to first finish calculation of all the results and statistics, and only after that to reset the states.

@DLochmelis33
Copy link
Collaborator

we want to first finish calculation of all the results and statistics, and only after that to reset the states.

Sure, but at this point each thread only operates on its own chunk of states, so there are no conflicts anyway

Signed-off-by: Evgeniy Moiseenko <evg.moiseenko94@gmail.com>
@eupp
Copy link
Member Author

eupp commented Jan 20, 2025

Sure, but at this point each thread only operates on its own chunk of states, so there are no conflicts anyway

Ah, yes, I think you are right. I left only one barrier in the code.

@eupp eupp merged commit 8aa69b5 into development Jan 20, 2025
@eupp eupp deleted the bugfix-add-barriers branch January 20, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants